Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planetside and space elevator #4

Merged
merged 4 commits into from
Dec 29, 2024
Merged

planetside and space elevator #4

merged 4 commits into from
Dec 29, 2024

Conversation

MilonPL
Copy link
Collaborator

@MilonPL MilonPL commented Dec 27, 2024

About the PR

changes arrivals to be a snow map because i like snow
adds the roundstart planet and a space elevator connected to it
The Great Plains for now, but I'm not sure if I'm happy with it, because it's hot but still a breathable atmosphere
maybe I will swap it to some planet with a very thin atmosphere

the space elevator needs to be mapped in too on all maps, it has a weird shape to prevent other shuttles from taking the port
alternatively it can also be mapped mid-station probably

image

image

image

@MilonPL MilonPL requested review from a team as code owners December 28, 2024 00:34
@github-actions github-actions bot added Changes: YML Changes any yml files Changes: C# Changes any cs files Changes: Localization Changes any ftl files S: Needs Review labels Dec 28, 2024
Copy link
Contributor

@Monotheonist Monotheonist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't read C# for fucking shit so I'm gonna blindly trust that everything is alright.

I like the snowy planet, but feel free to change it up, and figure out what we're doing.

Otherwise the yaml and locale that isn't the bulk of this looks kinda fine. We can argue over the locale folder name for my PR and your pr later because they're seperated by a underscore :3

@MilonPL
Copy link
Collaborator Author

MilonPL commented Dec 29, 2024

whats the worst that could happen :trollface:

@MilonPL MilonPL merged commit 1dc0ed1 into master Dec 29, 2024
12 checks passed
@MilonPL MilonPL deleted the planetside branch December 29, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Map Changes: UI Changes: YML Changes any yml files S: Needs Review size/XL Over 5000 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants